Skip to content

Add OTel log support to Carnot plan protos and implement exec node support#2161

Merged
ddelnano merged 3 commits intopixie-io:mainfrom
ddelnano:ddelnano/add-carnot-exec-node-otel-support
Apr 28, 2025
Merged

Add OTel log support to Carnot plan protos and implement exec node support#2161
ddelnano merged 3 commits intopixie-io:mainfrom
ddelnano:ddelnano/add-carnot-exec-node-otel-support

Conversation

@ddelnano
Copy link
Copy Markdown
Member

@ddelnano ddelnano commented Mar 28, 2025

Summary: Add OTel log support to Carnot plan protos and implement exec node support

My upcoming Kubecon talk will be demoing functionality that would benefit from OTel export log support. This is the first step in supporting this. The next set of PRs will include the planner and pxl frontend changes to leverage these changes.

Relevant Issues: #705

Type of change: /kind feature

Test Plan: New tests verify added functionality

@ddelnano ddelnano requested review from a team as code owners March 28, 2025 06:37
@ddelnano ddelnano force-pushed the ddelnano/add-carnot-exec-node-otel-support branch 2 times, most recently from 24aba91 to 662c3d6 Compare March 28, 2025 20:31
@ddelnano
Copy link
Copy Markdown
Member Author

ddelnano commented Mar 28, 2025

@pixie-io/core-maintainers I believe the pr-genfiles build broke with our recent Go 1.24 upgrade (likely kubernetes-sigs/controller-tools#888).

We need to upgrade our controller-tools to address this issue, but I believe it should be ok to ignore that for this PR. I'll be following up with the controller-tools change soon.

@ddelnano ddelnano force-pushed the ddelnano/add-carnot-exec-node-otel-support branch from 662c3d6 to f5ab311 Compare April 15, 2025 03:12
@ddelnano
Copy link
Copy Markdown
Member Author

ddelnano commented Apr 15, 2025

@pixie-io/maintainers the pr-genfiles issue is fixed and this is ready for review now.

exec node support

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
(cherry picked from commit ac0d014)
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
@ddelnano ddelnano force-pushed the ddelnano/add-carnot-exec-node-otel-support branch from f5ab311 to aae6ebc Compare April 28, 2025 14:50
@ddelnano ddelnano merged commit 920baba into pixie-io:main Apr 28, 2025
25 checks passed
@ddelnano ddelnano deleted the ddelnano/add-carnot-exec-node-otel-support branch April 28, 2025 18:31
ddelnano added a commit to ddelnano/pixie that referenced this pull request Aug 6, 2025
…pport (pixie-io#2161)

Summary: Add OTel log support to Carnot plan protos and implement exec
node support

My upcoming Kubecon talk will be demoing functionality that would
benefit from OTel export log support. This is the first step in
supporting this. The next set of PRs will include the planner and pxl
frontend changes to leverage these changes.

Relevant Issues: pixie-io#705

Type of change: /kind feature

Test Plan: New tests verify added functionality

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
GitOrigin-RevId: 920baba
ddelnano added a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
…pport (pixie-io#2161)

Summary: Add OTel log support to Carnot plan protos and implement exec
node support

My upcoming Kubecon talk will be demoing functionality that would
benefit from OTel export log support. This is the first step in
supporting this. The next set of PRs will include the planner and pxl
frontend changes to leverage these changes.

Relevant Issues: pixie-io#705

Type of change: /kind feature

Test Plan: New tests verify added functionality

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano added a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
…pport (pixie-io#2161)

Summary: Add OTel log support to Carnot plan protos and implement exec
node support

My upcoming Kubecon talk will be demoing functionality that would
benefit from OTel export log support. This is the first step in
supporting this. The next set of PRs will include the planner and pxl
frontend changes to leverage these changes.

Relevant Issues: pixie-io#705

Type of change: /kind feature

Test Plan: New tests verify added functionality

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants